Debuggability methods #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qfox
force-pushed
the
qfox.debuggability
branch
from
977212a
to
9440660
Compare
tadatuta
approved these changes
Jan 17, 2017
| @@ -129,6 +132,93 @@ const cell = new BemCell({ | |||
| cell.id; // ➜ "button__text@desktop.css" | |||
| ``` | |||
|
|
|||
| ### toString() | |||
|
|
|||
| Returns string representing this cell. | |||
|
|
||
| ### valueOf() | ||
|
|
||
| Returns object representing this cell. |
|
|
||
| ### toJSON() | ||
|
|
||
| Returns object for `JSON.stringify()` purposes. |
There was a problem hiding this comment.
Returns an object
and not sure about purposes, shouldn't it be in singular?
| // ➜ BemCell { entity: { block: 'input', mod: { name: 'available' } }, tech: 'css' } | ||
| ``` | ||
|
|
||
| You can also convert `BemCell` object to `string`. |
qfox
force-pushed
the
qfox.debuggability
branch
from
9440660
to
e0217ac
Compare
|
@tadatuta <3 ty |
qfox
force-pushed
the
qfox.debuggability
branch
from
e0217ac
to
637e9ff
Compare
blond
requested changes
Jan 18, 2017
| entity: new BemEntityName({ block: 'button', mod: 'focused' }) | ||
| }); | ||
|
|
||
| cell.toString(); // button_focused |
There was a problem hiding this comment.
Лучше все поля в примере показать, чтобы не путать с BemEntityName.
|
|
||
| cell.valueOf(); | ||
|
|
||
| // ➜ { entity: { block: 'button', mod: { name: 'focused', value: true } } } |
| * In some browsers `console.log()` calls `valueOf()` on each argument. | ||
| * This method will be called to get custom string representation of the object. | ||
| * | ||
| * The representation object contains only `block`, `elem` and `mod` fields |
There was a problem hiding this comment.
не нужно уточнить, что это про entity поле?
| entity: new BemEntityName({ block: 'block' }) | ||
| }); | ||
|
|
||
| t.truthy(typeof cell.toString() === 'string'); |
There was a problem hiding this comment.
Может ещё проверять, что id равен toString?
There was a problem hiding this comment.
А точно есть смысл? Нам же не особо важен формат
Yeti-or
reviewed
Jan 24, 2017
| * | ||
| * @returns {string} | ||
| */ | ||
| toString() { return this.id; } |
There was a problem hiding this comment.
by the way why not
path.join(this.layer || '', this.entity) ?
blond
approved these changes
Jan 26, 2017
qfox
force-pushed
the
qfox.debuggability
branch
from
a29b345
to
d266974
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.