Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BemCell.isBemCell #11

Merged
merged 3 commits into from
Jan 18, 2017
Merged

BemCell.isBemCell #11

merged 3 commits into from
Jan 18, 2017

Conversation

qfox
Copy link
Contributor

@qfox qfox commented Jan 17, 2017

Fixes #9

@tadatuta
Copy link
Member

can't it be implemented as

static isBemCell(cell) {
    return cell && this.name === cell.constructor.name;
}

to avoid extra field in each instance?

@qfox
Copy link
Contributor Author

qfox commented Jan 17, 2017 •
edited

to avoid extra field in each instance?

Ok, let's try!

@qfox qfox requested review from tadatuta and blond January 18, 2017 00:10
tadatuta
tadatuta approved these changes Jan 18, 2017
View reviewed changes
Copy link
Member

@tadatuta tadatuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@qfox qfox merged commit b6c9b24 into master Jan 18, 2017
@qfox qfox deleted the qfox.isbemcell branch January 18, 2017 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadatuta tadatuta tadatuta approved these changes

@blond blond Awaiting requested review from blond

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@qfox @tadatuta