Add styleToObj tests

bem-sdk-archive · Apr 19, 2017 · 303b573 · 303b573
1 parent 008f7d2
commit 303b573
Show file tree

Hide file tree

Showing 4 changed files with 41 additions and 26 deletions.
diff --git a/lib/helpers.js b/lib/helpers.js
@@ -26,8 +26,22 @@ function objToStr(obj) {
     return `{ ${keys.map(k => propToStr(k, obj[k])).join(', ')} }`;
 }
 
+function styleToObj(style) {
+    if (typeof style === 'string') {
+        return style.split(';').reduce((acc, st) => {
+            if (st.length) {
+                var prop = st.split(':');
+                acc[prop[0]] = prop[1];
+            }
+            return acc;
+        }, {});
+    }
+    return style;
+}
+
 module.exports = {
     objToStr,
     arrToStr,
+    styleToObj,
     valToStr
 };
diff --git a/lib/index.js b/lib/index.js
@@ -4,6 +4,7 @@ var pascalCase = require('pascal-case');
 
 var reactMappings = require('./reactMappings');
 var valToStr = require('./helpers').valToStr;
+var styleToObj = require('./helpers').styleToObj;
 
 var plugins = require('./plugins');
 
@@ -17,12 +18,12 @@ function JSXNode(tag, props, children) {
 }
 
 var propsToStr = props => Object.keys(props).reduce((acc, k) => {
-        if (typeof props[k] === 'string') {
-            return acc + ` ${k}=${valToStr(props[k])}`
-        } else {
-            return acc + ` ${k}={${valToStr(props[k])}}`
-        }
-    }, '');
+    if (typeof props[k] === 'string') {
+        return acc + ` ${k}=${valToStr(props[k])}`
+    } else {
+        return acc + ` ${k}={${valToStr(props[k])}}`
+    }
+}, '');
 var tagToClass = tag => reactMappings[tag] ? tag : pascalCase(tag);
 
 JSXNode.prototype.toString = function() {
@@ -140,6 +141,7 @@ Transformer.prototype.Transformer = Transformer;
 module.exports = function(opts) {
     return new Transformer(opts || {});
 };
+
 module.exports.tagToClass = tagToClass;
 module.exports.plugins = plugins;
-module.exports.styleObj = plugins.helpers.styleObj;
+module.exports.styleToObj = styleToObj;
diff --git a/lib/plugins.js b/lib/plugins.js
@@ -1,3 +1,4 @@
+var styleToObj = require('./helpers').styleToObj;
 
 module.exports.defaultPlugins = [
     function copyMods(jsx, bemjson) {
@@ -15,16 +16,12 @@ module.exports.defaultPlugins = [
             jsx.props[k] = bemjson[k];
         });
     },
-    function styleToObj(jsx) {
+    function stylePropToObj(jsx) {
         jsx.props['style'] &&
-            (jsx.props['attrs']['style'] = jsx.props['style'] = styleObj(jsx.props['style']));
+            (jsx.props['attrs']['style'] = jsx.props['style'] = styleToObj(jsx.props['style']));
     }
 ];
 
-module.exports.helpers = {
-    styleObj: styleObj
-};
-
 module.exports.whiteList = function(options) {
     options = options || {};
     return function(jsx) {
@@ -36,15 +33,3 @@ module.exports.whiteList = function(options) {
     }
 };
 
-function styleObj(style) {
-    if (typeof style === 'string') {
-        return style.split(';').reduce((acc, st) => {
-            if (st.length) {
-                var prop = st.split(':');
-                acc[prop[0]] = prop[1];
-            }
-            return acc;
-        }, {});
-    }
-    return style;
-}
diff --git a/test/helpers.js b/test/helpers.js
@@ -1,6 +1,8 @@
 const expect = require('chai').expect;
 
-const objToStr = require('../lib/helpers').objToStr;
+const helpers = require('../lib/helpers');
+const objToStr = helpers.objToStr;
+const styleToObj = helpers.styleToObj;
 
 
 describe('helpers: objToStr', () => {
@@ -58,3 +60,15 @@ describe('helpers: objToStr', () => {
         });
     });
 });
+
+describe('helpers: styleToObj', () => {
+    it('should transform style string to style obj', () => {
+        var obj = styleToObj('width:200px;height:100px;');
+        expect(obj).to.eql({ width: '200px', height: '100px' });
+    });
+
+    it('should not transform style obj to smth else', () => {
+        var obj = { width: '200px', height: '100px' };
+        expect(obj).to.eql({ width: '200px', height: '100px' });
+    });
+});