Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve nested entities #23

Merged
merged 1 commit into from
Jun 5, 2017

Conversation

smdenis
Copy link

@smdenis smdenis commented Jun 1, 2017

var bemjson = {
    block: 'button2',
    mods: { theme: 'normal', size: 'm' },
    text: 'hello world',
    icon: {block: 'test', mods: {'test-mod': 'yes'}} // Resolve components in this case
};

@smdenis
Copy link
Author

smdenis commented Jun 1, 2017

cc @Yeti-or

@smdenis smdenis force-pushed the smd.nested.blocks branch 2 times, most recently from 07e0e2a to 656f429 Compare June 1, 2017 13:26
@coveralls
Copy link

Coverage Status

Coverage decreased (-2.8%) to 96.735% when pulling 656f429 on creedencewright:smd.nested.blocks into cba2209 on bem-sdk:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 100.0% when pulling 360e0a1 on creedencewright:smd.nested.blocks into cba2209 on bem-sdk:master.

@@ -41,7 +41,7 @@ var bemjson = {

var jsxTree = bemjsonToJSX.process(bemjson);

console.log(jsxTree.JSX));
console.log(jsxTree.JSX);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 100.0% when pulling ecc55d5 on creedencewright:smd.nested.blocks into cba2209 on bem-sdk:master.

lib/index.js Outdated
}

return jsx;
}.bind(this);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prob you should use arrow function here?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 100.0% when pulling 9ac30f2 on creedencewright:smd.nested.blocks into cba2209 on bem-sdk:master.

@Yeti-or Yeti-or merged commit 376048a into bem-sdk-archive:master Jun 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants