Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

input: Rename to textinput #1447

Open
narqo opened this issue Mar 27, 2015 · 8 comments
Open

input: Rename to textinput #1447

narqo opened this issue Mar 27, 2015 · 8 comments
Assignees
@tadatuta
Labels
ready
Milestone
v5.0

Comments

@narqo
Copy link
Member

narqo commented Mar 27, 2015

It fills like the name of the input block is the source of frequent requests to implement strange things like input_type_hidden (#1379, #1441 for example).

input is really weird name, as it is too abstract for our implementation, comparing to HTML's <input>. So I propose to rename the block to textinput, as such name reflects the behaviour of the block more clearly.
@aristov aristov removed the question label Apr 2, 2015
@aristov aristov added this to the v3.0 milestone Apr 2, 2015
@aristov
Copy link
Contributor

aristov commented Apr 2, 2015

👍 me and @veged 👍

@qfox
Copy link
Member

qfox commented Apr 2, 2015

And mine 👍

@tadatuta
Copy link
Member

tadatuta commented Apr 2, 2015

everybody loves refactoring so 👍

@qfox
Copy link
Member

qfox commented Apr 2, 2015

@tadatuta 🎉 :-D

@Guria Guria mentioned this issue Apr 15, 2015
Closed
@veged veged added the ready label Apr 29, 2015
@tadatuta
Copy link
Member

I think it should be postponed till v5

@tadatuta tadatuta removed this from the v3.0 milestone Apr 19, 2016
@tadatuta tadatuta self-assigned this Apr 19, 2016
@tadatuta tadatuta removed the v3 label Apr 19, 2016
@tadatuta tadatuta added this to the v5.0 milestone Apr 19, 2016
@veged
Copy link
Member

veged commented Apr 19, 2016

why?

@tadatuta
Copy link
Member

@veged I sent a mail with explanation a while ago

@veged
Copy link
Member

veged commented Apr 20, 2016 •
edited
Loading

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tadatuta tadatuta

Labels
ready
Projects
None yet
Milestone
v5.0
Development

No branches or pull requests
5 participants
@veged @narqo @tadatuta @qfox @aristov