Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[menu] global context properties #1516

Closed
Guria opened this issue May 27, 2015 · 5 comments
Closed

[menu] global context properties #1516

Guria opened this issue May 27, 2015 · 5 comments

Comments

@Guria
Copy link
Contributor

Guria commented May 27, 2015

_firstItem and _checkedItems properties set as global in context.

          { block:'menu', content:[{block:'menu-item', content:'asdasd'}]},
          { block: 'debug'},
block('debug').content()(function(){
    return JSON.stringify(this._firstItem);
});
<div class="menu menu__control i-bem" data-bem="{&quot;menu&quot;:{}}" role="menu" tabindex="0">
  <div class="menu-item i-bem" data-bem="{&quot;menu-item&quot;:{}}" role="menuitem">asdasd</div></div>
<div class="debug">{"block":"menu-item","content":"asdasd","mods":{}}</div>
@narqo
Copy link
Member

narqo commented May 27, 2015

Nice catch, thanks! We will fix it in the nearest future

@narqo
Copy link
Member

narqo commented May 28, 2015

Actually, it shouldn't hurt any "real life" usage (as these flags will be reassigned for each menu instance).

But anyway, could you make a separate PR for the issue, so we will merge it?

@Guria
Copy link
Contributor Author

Guria commented May 28, 2015

Okay

@qfox
Copy link
Member

qfox commented May 29, 2015

👍 for that fix but looks like it's breaking change.

@Guria
Copy link
Contributor Author

Guria commented May 29, 2015

@zxqfox #1523 just bug fix, #1520 more serious change but I don't see what it can brake

@narqo narqo removed the ready label Jun 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants