Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The modal__autocloseable closes immediately after opening in touch browsers (touch events) #1958

Closed
veged opened this issue Nov 14, 2016 · 4 comments

Comments

@veged
Copy link
Member

veged commented Nov 14, 2016

Button opens modal with autocloseable modifier. After click modal shows a one moment. It's happens because modal catches 'click' event. The 'click' event is a program event after 'touchend'.

I can reproduce in iOS (bem-core#v4), AndroidBrowser (bem-core#v4, bem-core#v3), Chrome for Android (bem-core#v4, bem-core#v3), Chromium on Windows 10 with touchscreen (bem-core#v4, bem-core#v3).

@vsesh

@veged
Copy link
Member Author

veged commented Nov 14, 2016

@vsesh Can you say in which Android versions this can be reproduced?

@veged
Copy link
Member Author

veged commented Nov 14, 2016

Looks like we can move click emiting from https://github.com/bem/bem-components/blob/v4/common.blocks/button/button.js#L119 to pointerclick.

@vsesh
Copy link

vsesh commented Nov 14, 2016

@veged I could reproduce in Android 4.x and 5.0.

@narqo
Copy link
Member

narqo commented Nov 14, 2016

@vsesh doesn't meta with device-width solve the problem?

<meta name="viewport" content="width=device-width, initial-scale=1, minimum-scale=1, maximum-scale=3">

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants