Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link_disabled: mustn't have appearance as an active link #2004

Closed
dfilatov opened this issue Feb 23, 2017 · 10 comments
Closed

link_disabled: mustn't have appearance as an active link #2004

dfilatov opened this issue Feb 23, 2017 · 10 comments

Comments

@dfilatov
Copy link
Member

Currently it has the same color, hover state and so on.

@tadatuta
Copy link
Member

It was considered as won't fix in #537 (see https://nda.ya.ru/3SeuJu for details).

@dfilatov
Copy link
Member Author

dfilatov commented Feb 24, 2017

But it looks really weird. I have a set of link_pseudo which mustn't be available unless some condition is satisfied. And appearance should help users rather than confuse them.

@birhoff
Copy link
Contributor

birhoff commented Feb 26, 2017

Where i can like for this as a bug?

@tadatuta
Copy link
Member

All we need to fix it is official appearance for disabled link in islands theme.
I'll try to ask in internal mail once again.

@tadatuta
Copy link
Member

Oh, I found styles in islands repo: https://nda.ya.ru/3SfY2o
Let's use them in bem-components as well.

@dfilatov
Copy link
Member Author

@tadatuta Could you port it to v4 at least?

@tadatuta
Copy link
Member

sure

@dfilatov
Copy link
Member Author

and would be kind if to v3 as well )

@tadatuta
Copy link
Member

done

@dfilatov
Copy link
Member Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants