Safe lazyInit for declMod #1584
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
belozer
force-pushed
the
issues/1583@v4
branch
4 times, most recently
from
e02661e
to
05f66af
Compare
belozer
commented
Jul 26, 2018
| * @returns {?Boolean} | ||
| */ | ||
| function processLazyInitRule(entity, mod, lazyInit) { | ||
| var rules = entity._lazyInitRules; |
There was a problem hiding this comment.
В переменной нет смысла вообще. Нужно выбросить.
belozer
commented
Jul 26, 2018
| * @param {Function} entity BemDomEntity | ||
| * @param {Object} mod mod declaration | ||
| * @param {Boolean} lazyInit lazyInit behavior | ||
| * @returns {?Boolean} |
There was a problem hiding this comment.
Ничего не возвращает. Походу опечатка.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #1583