Support custom modifier separator #76
Conversation
|
lgtm |
|
🆙 |
|
still lgtm :) |
| * **String** `name` — separates name of modifier from blocks and elements. Default as `_`. | ||
| * **String** `val` — separates value of modifier from name of modifier. Default as the value of the `name`. | ||
|
|
||
| * **String** `modVal` — separates value of modifier from name of modifier. Default as the value of the `mod` option. |
There was a problem hiding this comment.
It's looks like neprisheikpeacedeadrookave. Do we really need it?
* Support `mod` option as object * Add `modValDelim` field
|
@zxqfox I removed |
|
👍 ok, thanks ;-) |
Add `mod.val` option with `_` value and add test cases for this option.
Update graceful-fs to version 4.1.11 🚀
|
@blond Also, you can notice that a lot of people not aware of changes and still use old way with For example, there it's still We are implementing BEM now in our team and we are confused. |
|
@seyfer actually underscore was historically first demimiter originated from Yandex. But right now we tend to switch to so called React style. Still the main point here is that any particular scheme does not matter while all the code base of a project is consistent. |
|
@tadatuta Feels like we should make a faq for naming related questions. |
Resolved #69
modValDelimfield.modas object:mod: { name: String, val: String }.mod: { name: '--', val: '_' }.