This repository has been archived by the owner on Sep 21, 2022. It is now read-only.
Some refactoring to run grep before tests run #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
hatroman
force-pushed
the
feature/grep-before-tests
branch
from
1451f67
to
f8e1a42
Compare
1 similar comment
hatroman
force-pushed
the
feature/grep-before-tests
branch
from
f8e1a42
to
61ede4f
Compare
1 similar comment
| @@ -28,123 +29,125 @@ function requireWithNoCache(moduleName) { | |||
| return result; | |||
| } | |||
|
|
|||
| module.exports = inherit(ChainedEmitter, { | |||
| module.exports = inherit(EventEmitter, { | |||
There was a problem hiding this comment.
Why?
ChainedEmmiter was there for the plugins needs. Basically, it allows to return a promise from event handler and delay the further execution until that promise resolves. This allows, for example, to launch SauceConnect or ssh-tunnel before any tests are launched.
There was a problem hiding this comment.
По коду это совершенно непонятно, а то единственное использование ChainedReporter, что я нашел, выглядело очень натянуто.
Либо как-то странно реализована поддержка плагинов, либо нужно более явно в коде объяснить, почему нужно делать именно так, а не иначе.
Плохое архитектурное решение, кмк.
hatroman
force-pushed
the
feature/grep-before-tests
branch
from
61ede4f
to
4ae5670
Compare
hatroman
force-pushed
the
feature/grep-before-tests
branch
2 times, most recently
from
11be320
to
64ae9e1
Compare
hatroman
force-pushed
the
feature/grep-before-tests
branch
from
64ae9e1
to
1a92664
Compare
1 similar comment
hatroman
force-pushed
the
feature/grep-before-tests
branch
from
1a92664
to
111fcf5
Compare
SevInf
pushed a commit
that referenced
this pull request
Apr 16, 2015
Some refactoring to run grep before tests run
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.