This repository has been archived by the owner on Sep 21, 2022. It is now read-only.
Allow to launch one WD session per suite #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @j0tunn |
1 similar comment
| @@ -73,6 +73,9 @@ browsers: | |||
| * `debug` (CLI: `--debug`, env: `GEMINI_DEBUG`) – включить отладочный вывод в терминал. | |||
| * `parallelLimit` – число браузеров запускаемых `Gemini` параллельно. | |||
| По умолчанию запускаются все, но иногда (например, при использовании облачных сервисов вроде Sauce Labs) это число необходимо контролировать. | |||
| * `sessionMode` — позволяет указать, как именно запускать новые сессии WebDriver: | |||
| - `perBrowser` (по умолчанию) — запуск одной сессии для каждого браузера. Эта сессия будет переиспользована для всех наборов. | |||
| - `perSuite` — запуск 1 сессия в каждом браузере для каждого набора. Сессия будет закрыта как только набор протестирован. | |||
SevInf
force-pushed
the
feature/session-per-suite
branch
from
bec1d32
to
332a54f
Compare
1 similar comment
| * @param {String} id | ||
| */ | ||
| BasicPool.prototype.finalizeBrowsers = function(id) { | ||
| }; |
There was a problem hiding this comment.
Почему бы не так?
module.exports = _.assign(BasicPool.prototype, {
/**
* @param {String} id
* @returns {Promise.<Browser>}
*/
getBrowser: function(id) {
},
/**
* @param {Browser} browser
* @returns {Promise}
*/
freeBrowser: function(browser) {
},
/**
* @param {String} id
*/
finalizeBrowsers: function(id) {
}
});There was a problem hiding this comment.
Можно и так, но у меня tern с таким вариантом лучше работает.
SevInf
force-pushed
the
feature/session-per-suite
branch
2 times, most recently
from
ac02eca
to
63c9661
Compare
| }) | ||
| .then(function() { | ||
| return browser.captureFullscreenImage(); | ||
| }) |
| }) | ||
| .then(function() { | ||
| return _this.browserPool.freeBrowser(browser); | ||
| }); |
SevInf
force-pushed
the
feature/session-per-suite
branch
from
63c9661
to
2f9776e
Compare
|
🆙 |
| .then(function() { | ||
| return session.runHook(suite.afterHook); | ||
| }) | ||
| .then(function() { |
There was a problem hiding this comment.
а тут не надо это делать в fin?
|
Есть предложение сделать |
SevInf
force-pushed
the
feature/session-per-suite
branch
from
2f9776e
to
f6e7cab
Compare
added 2 commits
April 16, 2015 17:08
sessionMode option added which allows to switch between perBrowser (1 session for browser, current behavior) and perSuite (1 session for each suite). To support both old and new behavior along with parallelLimit setting, browser launcher was replaced with 3 pool classes. New browser is requested from pool before each suite. `Pool` class is the most simple variant of the pool which just opens and closes session every time it requested. `LimitedPool` wraps another pool and enforces the limit on the number of currently open sessions. It is used when parallelLimit is set. In perBrowser mode, limited or unlimited pool will be wrapped in CachingPool which allows to share a session between multiple suites. As long as calibration is needed to be performed only once for each browser id, it was moved to separate Calibrator class. This allows to perform only once for each browser even in perSuite mode.
|
Changes Unknown when pulling f6e7cab on feature/session-per-suite into * on master*. |
2 similar comments
|
Changes Unknown when pulling f6e7cab on feature/session-per-suite into * on master*. |
|
Changes Unknown when pulling f6e7cab on feature/session-per-suite into * on master*. |
SevInf
force-pushed
the
feature/session-per-suite
branch
from
f6e7cab
to
34aac8c
Compare
|
Changes Unknown when pulling 34aac8c on feature/session-per-suite into * on master*. |
|
🆗 |
SevInf
pushed a commit
that referenced
this pull request
Apr 16, 2015
Allow to launch one WD session per suite
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sessionMode option added which allows to switch between
perBrowser (1 session for browser, current behavior) and
perSuite (1 session for each suite).
To support both old and new behavior along with parallelLimit
setting, browser launcher was replaced with 3 pool classes.
New browser is requested from pool before each suite.
In perSuite mode, one of the following classes will be used:
In perBrowser mode, limited or unlimited pool will be wrapped
in CachingPool which allows to share a session between multiple
suites.
As long as calibration is needed to be performed only once for
each browser id, it was moved to separate Calibrator class. This
allows to perform only once for each browser even in perSuite mode.