Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NaNs in path #99

Closed
Egor812 opened this issue Jan 23, 2020 · 4 comments
Closed

NaNs in path #99

Egor812 opened this issue Jan 23, 2020 · 4 comments
Labels

Comments

@Egor812
Copy link

Egor812 commented Jan 23, 2020

Wrong conversion of Fontawesome icon:
<svg aria-hidden="true" focusable="false" data-prefix="fas" data-icon="phone-square" class="svg-inline--fa fa-phone-square fa-w-14" role="img" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 448 512"><path fill="currentColor" d="M400 32H48C21.49 32 0 53.49 0 80v352c0 26.51 21.49 48 48 48h352c26.51 0 48-21.49 48-48V80c0-26.51-21.49-48-48-48zM94 416c-7.033 0-13.057-4.873-14.616-11.627l-14.998-65a15 15 0 0 1 8.707-17.16l69.998-29.999a15 15 0 0 1 17.518 4.289l30.997 37.885c48.944-22.963 88.297-62.858 110.781-110.78l-37.886-30.997a15.001 15.001 0 0 1-4.289-17.518l30-69.998a15 15 0 0 1 17.16-8.707l65 14.998A14.997 14.997 0 0 1 384 126c0 160.292-129.945 290-290 290z"></path></svg>
converts to
<symbol id="icon-phone-square-solid" viewBox="0 0 448 512"> <path d="M400 32H48C21.49 32 0 53.49 0 80v352c0 26.51 21.49 48 48 48h352c26.51 0 48-21.49 48-48V80c0-26.51-21.49-48-48-48zM94 416c-7.033 0-13.057-4.873-14.616-11.627l-14.998-65a15 15 0 18.707-17.16 NaN NaNlNaN NaNa15 15 0 117.518 4.289 NaN NaNlNaN NaNcNaN NaN NaN NaN NaN NaNlNaN NaNa15.001 15.001 0 1-4.289 NaN NaNlNaN NaNa15 15 0 117.16-8.707 NaN NaNlNaN NaNa14.997 14.997 0 1384 126 NaN NaNcNaN NaN NaN NaN NaN NaNz"></path> </symbol>

@rejas
Copy link
Collaborator

rejas commented Jan 23, 2020

could you please provide which version of gulp-svgmin you are using?

@s-pyadyshev
Copy link

I have the same issue with "gulp-svgmin": "^1.2.4",

@rejas
Copy link
Collaborator

rejas commented Feb 8, 2020

HI @s-pyadyshev and @Egor812 could you chck if using the branch "cleanups" https://github.com/ben-eb/gulp-svgmin/tree/cleanup fixes your problems?

@ben-eb
Copy link
Owner

ben-eb commented Mar 8, 2021

Hey @Egor812 , please could you report this to https://github.com/svg/svgo if you are still having this issue? This plugin is a thin wrapper on top of svgo to use it with gulp, and so this is better reported upstream. Thanks. 👍

@ben-eb ben-eb closed this as completed Mar 8, 2021
@ben-eb ben-eb added the upstream label Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants