-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSV library fails to link on Windows with Threads ON #24
Comments
Hi,
if I understand you correctly, then the error that you are getting is
C:/projects/nupic-core/external/common/include/csv.h:275:30: error:
'thread' in namespace 'std' does not name a type
which means that your compiler is broken in the sense that it does not
implement the C++11 standard threading interface (in the year 2016!) and
is thus not supported. If you use a compiler which does implement C++11,
such as I believe the newer VC++ compilers, then the library will also
compile on Windows.
I will not reimplement stuff in terms of the native Windows threading
functions just because some compiler vendor fails at its job of
providing standardized interfaces.
You have two options:
1. Stick with -DCSV_IO_NO_THREAD
2. Fix your compiler. I believe the following links could be of help to
you
http://stackoverflow.com/questions/21211980/mingw-error-thread-is-not-a-member-of-std
and https://github.com/meganz/mingw-std-threads
Best Regards
Ben Strasser
|
Ben, thank you for the helpful links! We are using FYI @rcrowder maybe you'll be able to give a better insight |
Apologies for commenting on this closed issue. We do use a posix and seh GCC variant on Windows for building the C++ nupic.core (MinGWPy), but don't require pthread (or winpthread) support within the core itself currently. With the various issues with thread and exception handling on MinGW-w64 based GCC variants, I'm inclined to stick with the CSV_IO_NO_THREAD option right now (relying on Python to handle threading required in the nupic python code base across all supported OS). |
I have an issue linking the library to our project on Windows,
you can see the original report and Appveyor output at: numenta/nupic.core-legacy#890 (comment)
In the followup we tried adding
pthread
as suggested, but didn't help, so we resolved to a workaround with disabled multithreading on Win (-DCSV_IO_NO_THREAD
).It's not critical but would be nice if the Win version worked the same as on UNIXes.
The text was updated successfully, but these errors were encountered: