Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MacBook Pro 15" Mid-2014 and 10.5" iPad Pro Graininess #40

Closed
ruthloose88 opened this issue Feb 4, 2020 · 8 comments
Closed

MacBook Pro 15" Mid-2014 and 10.5" iPad Pro Graininess #40

ruthloose88 opened this issue Feb 4, 2020 · 8 comments
Labels
Apple Issue This issue can only be addressed by Apple no-issue-activity

Comments

@ruthloose88
Copy link

Just discovered this handy app and got SideCar enabled on my 2014 MBP, but the picture quality is very grainy with a wired connection. Just wondering if there is a terminal command I can use to improve the video quality.

ezgif com-video-to-gif

@ben-z ben-z added the Apple Issue This issue can only be addressed by Apple label Feb 5, 2020
@ben-z
Copy link
Owner

ben-z commented Feb 5, 2020

This is a common issue for newer iPads connected to older Macs. It happens because there is no hardware acceleration for HEVC. See past issues such as #4 for discussions.

@ruthloose88
Copy link
Author

ruthloose88 commented Feb 5, 2020

Thanks, @ben-z.

I tried your solution to #4 using a resolution solution like Display Monitor and Easy Res. Both provided no additional resolution options to select from, so I wonder if it is a GPU issue and the fact that that MacBook Pro has an Intel Iris Pro 1536 MB VRAM (built-in).

This may not be an issue for MBPs with a discrete GPU. and probably why my MBP was on Apple's blacklist in the first place .

@ben-z
Copy link
Owner

ben-z commented Feb 5, 2020

Ya the discussion in #4 didn't arrive at a solid conclusion...

The 15 inch MBP 2015 is on the blacklist as well though, so I'm suspecting it might not entirely be a GPU issue.

The T2 chip in newer Macs provide hardware HEVC acceleration. I'm suspecting that in Sidecar, there's a snippet that looks like:

if (MBP 2016 or MBP 2017) { # doesn't have T2 Chip
   use a special encoding
}

where the special encoding is one that is suitable for running on GPUs.

I'm wondering if we trick sidecar to recognize an MBP 2015 or older as a 2016/2017 MBP, it would provide a better quality.

@ruthloose88
Copy link
Author

ruthloose88 commented Feb 5, 2020

@ben-z , if you need a guinea pig, I'd be willing to edit the file to exclude that line of coding. Of course, part of me is wondering how much this might tax my laptop.

@ben-z
Copy link
Owner

ben-z commented Feb 5, 2020

We'll first have to figure out where that is in the SidecarCore binary 😄. If you are comfortable fiddling with it, please feel free to! A good tool is iHex Editor. I would start by looking up the device identifiers for MBP 2016 and MBP 2017 in SidecarCore and see if changing them has any effects.

Remember to always keep a backup!

@ruthloose88
Copy link
Author

@ben-z I may run the SidecarCore binary on my 2014 MBP and my 2018 MacBook Air (work computer) just to see how and if these differ (given that one is whitelisted and one is blacklisted). I'll give it a look later and see if it makes sense to dump the hex editor results or not here.

@ruthloose88
Copy link
Author

I'm not finding anything that references the T2 Chip, HEVC or H.265 encoding.

I did find a number of device configurations under the header "SidecarDisplayConfig" like "keyFrameInterval," "rtcp TimeoutInterval," "setLowLatency" and "setScale."

Nothing pops out at me that seems like the answer yet.

I am attaching a couple of finds from my 2018 MacBook Air Sidecar Core binary (started there to see if it referenced T2 or HEVC). I will look again later.

2018 MBA SideCar Core.txt

@github-actions
Copy link

github-actions bot commented Mar 7, 2020

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Apple Issue This issue can only be addressed by Apple no-issue-activity
Projects
None yet
Development

No branches or pull requests

2 participants