Upgrade the JavaParser dependency #9
Conversation
| String annotationPackageName = annotation | ||
| .findCompilationUnit() | ||
| .flatMap(CompilationUnit::getPackageDeclaration) | ||
| .flatMap(pkg -> Optional.of(pkg.getNameAsString())).orElse("???"); |
There was a problem hiding this comment.
Original code got a null when there is no package declaration. Not sure if that was the intention - it's ??? now.
There was a problem hiding this comment.
if there is no package declaration, then the annotation should declared in the default package right? What if we use an empty string as default value in the orElse?
| methodDao.save(new Method(annotationMemberDeclaration.getName(), | ||
| isPublic(annotationMemberModifiers), isStatic(annotationMemberModifiers), isFinal(annotationMemberModifiers), isAbstract(annotationMemberModifiers), false, typeId)); | ||
| methodDao.save(new Method(annotationMemberDeclaration.getNameAsString(), | ||
| annotationMemberDeclaration.isPublic(), false, false, annotationMemberDeclaration.isAbstract(), false, typeId)); |
There was a problem hiding this comment.
annotation interface members can't be static or final.
| List<Parameter> parameters = constructorDeclaration.getParameters(); | ||
| String name = constructorDeclaration.getName(); | ||
| String name = constructorDeclaration.getNameAsString(); |
There was a problem hiding this comment.
Names are now nodes instead of strings, so there's a helper method to get the string value.
|
Hi Danny, Happy to see you here! Thank you for this PR and thank you for the wonderful java parser library! I didn't have time to update this repo yet, it is still in PoC stage and the code was written in a quick and dirty manner. I was just trying to see if the idea works and if the relational model is good enough (see my blog post about it). Anyway, I will merge your changes asap. Best regards |
|
Cool! Just think of it like this: at least no potential user will be disappointed when it fails on parse errors on valid source code :-) (Actually, it would be best to completely disable AST validations then... hmmmm...) |
|
I have some time to work on jql this week. Thank you for your PR! |
There are a lot of known bugs in JavaParser 2.4.0, making this a rather urgent upgrade.