Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyper v1.0 #98

Merged
merged 2 commits into from Feb 4, 2017
Merged

Hyper v1.0 #98

merged 2 commits into from Feb 4, 2017

Conversation

RoxasShadow
Copy link
Contributor

@RoxasShadow RoxasShadow commented Feb 3, 2017

This PR upgrades hyper to the latest hyper version, which introduces asynchronous I/O thanks to tokio. Since they removed internal support to TLS/SSL, we'll get it from hyper-openssl.

Maybe we can give precedence to #97 as this PR is based on it.

@benashford
Copy link
Owner

Async I/O 🤔, that could be quite handy in future.

Before I merge, could you merge the latest master into this branch (or rebase). The diff seems to be confused as is, it's comparing the new branch with an old master before #97 was merged in. Updating this branch from master ought to clarify the history.

@KodrAus
Copy link

KodrAus commented Feb 3, 2017

I think hyper 0.10.x is still based on synchronous IO from the standard library. So there isn't even rotor anymore. But it's the "long-term support" version for a synchronous API so is worth updating to.

You can target the master branch of hyper to see what it's async API looks like. It'll mean pulling in dependencies on futures and tokio-core.

@RoxasShadow
Copy link
Contributor Author

I thought that hyper 0.10.* was relatively on the same line of updates of the master branch, but you made me realize that it is not as tokio is not a dependency of it.

Thanks for the highlight.

@benashford
Copy link
Owner

Cool, thanks 👍

I'll package the last two PRs as a v0.8.0 release later today.

@benashford benashford merged commit 49db810 into benashford:master Feb 4, 2017
@benashford
Copy link
Owner

Released as 0.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants