Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In rooms, names can only be up to 9 letters long. #44

Closed
samarmohan opened this issue Feb 12, 2021 · 4 comments
Closed

In rooms, names can only be up to 9 letters long. #44

samarmohan opened this issue Feb 12, 2021 · 4 comments
Projects

Comments

@samarmohan
Copy link
Contributor

No description provided.

@samarmohan samarmohan changed the title In rooms, names can be up to 9 letters long. In rooms, names can only be up to 9 letters long. Feb 12, 2021
@giuseppecampanelli
Copy link
Contributor

@samarmohan it's actually 10 characters

{(u.displayName || "").split(" ")[0]?.slice(0, 9)}

With 10, it ensures that no name goes onto a second line. Would have to see with @benawad

@samarmohan
Copy link
Contributor Author

samarmohan commented Feb 12, 2021

Well the code may say that but in practice it doesn't work.
image
I do have 2 "m"s so maybe that's why.

@giuseppecampanelli
Copy link
Contributor

@samarmohan yeah my bad, I forgot the endIndex on slice is exclusive.
Nonetheless, I believe it's limited to this to prevent spillover to a 2nd line. But maybe it can be increased 1-2 chars.

@benawad benawad added this to todo in main Feb 13, 2021
@benawad benawad moved this from todo to later in main Feb 13, 2021
@goldyydev
Copy link
Contributor

As far as I can see, this has been fixed (with the HTML truncating the text to fit a user's screen instead of a fixed JS slice)
image

main automation moved this from priority 4 to done Mar 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
main
done
Development

No branches or pull requests

3 participants