Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin does not work for markdown sources in collections #5

Closed
FokkeZB opened this issue Dec 13, 2016 · 7 comments
Closed

Plugin does not work for markdown sources in collections #5

FokkeZB opened this issue Dec 13, 2016 · 7 comments

Comments

@FokkeZB
Copy link

FokkeZB commented Dec 13, 2016

Markdown files with no front matter are copied to _site as-is, with no .html version.

I'd expect the plugin to work on markdown sources in collections as well.

@benbalter
Copy link
Owner

@FokkeZB are you saying that without the plugin they're converted to markdown, or that they're not copied at all? With the plugin, it sounds like they're copied but not rendered, is that correct?

@FokkeZB
Copy link
Author

FokkeZB commented Dec 13, 2016

What I mean is that Markdown files with no front matter that are part of collections are not processed by this plugin. As the source code shows it only processed pages.

@mcdemarco
Copy link

This would be especially helpful because Jekyll itself used to process files without frontmatter in collections, but stopped doing so in version 2.2.0. jekyll/jekyll-help#223

@benbalter
Copy link
Owner

I'd be glad to a review a PR if someone would like to make this opt-in for collections (e.g., via flag when the collection is describe in the config).

@stale stale bot added the wontfix label Aug 29, 2017
@stale
Copy link

stale bot commented Aug 29, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale
Copy link

stale bot commented Dec 3, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@kylekirkby
Copy link

kylekirkby commented Oct 24, 2019

@benbalter - Would be great to get this functionality added :) Looking to get the 96boards.org documentation into a pure markdown format!

BR,

Kyle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants