Provide mixed-case SPDX license identifier in response (e.g., as a 'spdx' value) #72
Comments
|
For now, it does not support multiple licenses (see #57). That said, all license names are outputted as their SPDX name and ID. Without multiple license support, is there need to support expressions? |
|
I don't think it currently provides exactly the SPDX name. The 'key' is close, but it's all lower case. As I understand it, SDPX names are case-sensitive, and include 'MIT', 'GPL-2.0', and 'Intel'. Upcasing works for 'mit' and 'gpl-2.0', but not for other licenses like 'Intel'. Can the key be exactly the SPDX name? If not, can you add a SPDX value as a result? BTW, I'm planning to use the GitHub license API, knowing it's still in flux, to get this data from GitHub. Of course it'd be WAY better if it could support multiple licenses :-). But just outputting SPDX values for single-license repos would be a big help. Thanks! |
Going off of the License Expression FAQ:
Is there another standard/place we should be looking? (I thought I went down this path when I first spec'd things out, the reason their down cased is because they are filenames on disk, and Git). |
|
The license expression syntax is case-insensitive (e.g., and, or). But I don't know that the license identifiers are case-insensitive. |
|
Downcasing for use as a key is perfectly sensible. But the SPDX 2.0 spec seems to be very precise about the upper/lower case value of license identifiers, so I'd really like to use the "official" names. I think you could just add that as a field that can be returned. |
david-a-wheeler
changed the title
|
Per http://wiki.spdx.org/view/Legal_Team/Minutes/2014-09-18 the license IDs are case-insensitive, but "best practice would be to display with precise capitalization". Can licensee provide a field (such as "spdx") with the mixed-case exact license ID name? |
|
This is now exposed as the |
|
Awesome! Thanks. |
The previous case-insensitive matching was removed in e5f46fa (test required spdx-ids against data from spdx, 2016-05-25, github#418). That commit was designed [1] to allow case-sensitive matching as discussed in [2]. But while I'm in favor of case-sensitive keys in spdx_list, the case-sensitive match breaks script/check-approval which downcases its argument since it was added in 8e56bb8 (add script/check-approval, 2016-01-18, github#318). [1]: github#418 (comment) [2]: licensee/licensee#72
The previous case-insensitive matching was removed in e5f46fa (test required spdx-ids against data from spdx, 2016-05-25, github#418). That commit was designed [1] to allow case-sensitive matching as discussed in [2]. But while I'm in favor of case-sensitive keys in spdx_list, the case-sensitive match breaks script/check-approval which downcases its argument since it was added in 8e56bb8 (add script/check-approval, 2016-01-18, github#318). There are more notes on SPDX's plans for case sensitivity in [3], so we should see a clearer policy there soon. I'm arguing for case-sensitive *display* with optional case-insensitive matching. I am optimistic that the SPDX will at least agree not to register short IDs that only differ by case, which is all we need to make this case-insensitive match safe here. [1]: github#418 (comment) [2]: licensee/licensee#72 [3]: spdx/spdx-spec#63
|
And with the just-landed #283, we've dropped the downcasing from |
It'd be great if this provided the SPDX 2.0 license name... or even better, a SPDX license expression where there are multiple licenses in a LICENSE{.md} file.
The text was updated successfully, but these errors were encountered: