-
-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Currency conversion #129
Comments
I think 2-4 are not possible to implement as Google loads this via javascript in the browser whereas Whoogle scrapes and parses the results from a no-javascript version of Google search results. @benbusby I thought it was possible to view (basic) results to such queries (1-3) using Whoogle. I remember it worked some versions ago (maybe I misremember). Currently on the latest version, none seem to work. Using the same query on Google no-js page ( Example queries;
Usually, the first |
This may make delay to implement this feature but it's not a problem, if we can go to next level than to google search then it'll be better too while privacy friendly. so i like to add a comment (enhancement request) about 2 and 3. I guess there're many free data providing services sites and APIs. (If that sounds like forcing, there's no thing like you should implement, that's only suggestions to make this project better 😄) Currency conversation i'm interest to see whoogle usable to view day/week/years currency statistics charts, contents from economic calendar and other details useful for particular field persons. it'll be amazing for other whoogle users. Weather It'll be better if it also able to display past and future weather details UI and some other useful contents. About "Calculator" Thank you for develop whoogle. 🥇 we like it alot 👍 app-0.5.0 |
Closing, since the issue is quite old at this point, and each of the OP's queries for basic currency conversion, weather, etc seem to all be working as expected. |
@benbusby Request to reopen, currency conversation doesn't work |
@accountForIssues has said,
if not possible, may be you can integrate any good solution as @urynon said,
I saw these resources, |
@benbusby I would like to give a more fully featured currency conversion a try. Basically, as we discussed in the mention above, I would use the
|
@vacom13 yeah, that all sounds correct I think. As long as the JS you write is all self-contained (i.e. doesn't rely on external libraries) that should work great. I'm guessing a simple way to do that would be to use the ratio found in the original query -- for example 1:74.19 -- and use that to calculate new results for all subsequent values the user enters into the input box. If you want to rely on an external service though, you'd need to offload the calculation to the server instead, and just use JS to query for results. |
@benbusby I was thinking of simply using the ratio to avoid using external services. Is that cool? And yes the js wont rely on external libraries. |
@vacom13 yep, that sounds great |
@benbusby just an update. I was thinking of making the regex when it hit me that a better way might be to just check for the disclaimer link in the first card of the search results and matching the |
@benbusby I keep getting this error please help. The The code I wrote still needs to be improved 😅 but here it is. |
@vacom13 you might want to disable the CSP while you're developing this. There's another issue in the backlog for removing it entirely, which I agree with, just haven't had a sec to do it yet. The line you'd want to remove is |
@benbusby okay great! |
@benbusby I have the feature down. Maybe I could just create a pr and you can check? |
@vacom13 for sure! Open a PR whenever you're ready |
Time
Whoogle display time in 24 format. search: pakistan time, google display it in AM/PM format
Currency conversation
This feature not available on whoogle. search: eur to usd
(You can attach cool component for that)
Weather
This feature not available on whoogle. search: pakistan weather or certain city weather
(You can ignore if difficult to implement)
Calculator
This feature not available for whoogle. search: calculator
(You may need to integrate other services if difficult to take from google)
So far i only expect solution for 1 and 2.
The text was updated successfully, but these errors were encountered: