Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login page for Whoogle #43

Closed
Panja0 opened this issue May 13, 2020 · 10 comments · Fixed by #51
Closed

Login page for Whoogle #43

Panja0 opened this issue May 13, 2020 · 10 comments · Fixed by #51
Labels
enhancement New feature or request Fixed (Pending PR Merge) A pull request is open for this issue

Comments

@Panja0
Copy link

Panja0 commented May 13, 2020

Describe the feature you'd like to see added
Login to Whoogle.

Describe which parts of the project this would modify (front end/back end/configuration/etc)
Probably both?

Additional context
Would it be possible to add a login page to Whoogle?
This way, when my Whoogle server is exposed to the internet it won't be hammered.
You will need to first login before you can use Whoogle.

@Panja0 Panja0 added the enhancement New feature or request label May 13, 2020
@s3rverro0m
Copy link

You do have the option of using OAuth if you wanted to? That may be an option!

@Panja0
Copy link
Author

Panja0 commented May 13, 2020

Thanks for the quick reply!
I have to look into this... Do you have some more info on this maybe?

@s3rverro0m
Copy link

s3rverro0m commented May 13, 2020

I use Keycloak in front of Traefik. What do you use as a reverse proxy?

Edit: https://www.keycloak.org

@Panja0
Copy link
Author

Panja0 commented May 13, 2020

I'm running Whoogle in Docker.
Docker is running on my Synology which uses NGINX as reverse proxy.

@s3rverro0m
Copy link

Check this out: https://edhull.co.uk/blog/2018-06-06/keycloak-nginx — uses docker-compose.

@s3rverro0m
Copy link

Granted, adding a login page would be easier as a whole, but at least this will allow you to secure all of your containers. It supports 2FA as well which is a big plus.

@Panja0
Copy link
Author

Panja0 commented May 13, 2020

Thanks! I'll have a look later on. Looks promising. Just like Whoogle itself! :-D
Love it!

I'll leave my enhancement request open.

@benbusby
Copy link
Owner

I like the idea of this in principle, but (depending on implementation) it might go a bit against the philosophy of keeping this as minimal and lightweight as possible. I can see implementing some form of really basic authentication -- maybe even literally HTTP Basic Auth -- but I'm not sure I'd want to go so far as to create a login page, local user db, etc just for this.

In any case it should definitely be an optional configuration setting to avoid any sort of delay between deployment and actually using the app. I'd even be open to it being set up as username/pw build args passed in the Dockerfile and then used by the Flask server to conditionally prompt for the basic auth dialog.

@Panja0
Copy link
Author

Panja0 commented May 15, 2020

Sounds good! Cheers
Keep up the good work! 😃

@benbusby
Copy link
Owner

Addressed in #51 (pending merge)

@benbusby benbusby added the Fixed (Pending PR Merge) A pull request is open for this issue label May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Fixed (Pending PR Merge) A pull request is open for this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants