-
-
Notifications
You must be signed in to change notification settings - Fork 903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Login page for Whoogle #43
Comments
You do have the option of using OAuth if you wanted to? That may be an option! |
Thanks for the quick reply! |
I use Keycloak in front of Traefik. What do you use as a reverse proxy? Edit: https://www.keycloak.org |
I'm running Whoogle in Docker. |
Check this out: https://edhull.co.uk/blog/2018-06-06/keycloak-nginx — uses docker-compose. |
Granted, adding a login page would be easier as a whole, but at least this will allow you to secure all of your containers. It supports 2FA as well which is a big plus. |
Thanks! I'll have a look later on. Looks promising. Just like Whoogle itself! :-D I'll leave my enhancement request open. |
I like the idea of this in principle, but (depending on implementation) it might go a bit against the philosophy of keeping this as minimal and lightweight as possible. I can see implementing some form of really basic authentication -- maybe even literally HTTP Basic Auth -- but I'm not sure I'd want to go so far as to create a login page, local user db, etc just for this. In any case it should definitely be an optional configuration setting to avoid any sort of delay between deployment and actually using the app. I'd even be open to it being set up as username/pw build args passed in the Dockerfile and then used by the Flask server to conditionally prompt for the basic auth dialog. |
Sounds good! Cheers |
Addressed in #51 (pending merge) |
Describe the feature you'd like to see added
Login to Whoogle.
Describe which parts of the project this would modify (front end/back end/configuration/etc)
Probably both?
Additional context
Would it be possible to add a login page to Whoogle?
This way, when my Whoogle server is exposed to the internet it won't be hammered.
You will need to first login before you can use Whoogle.
The text was updated successfully, but these errors were encountered: