Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to show the displayName text as label? #2

Closed
paule96 opened this issue Sep 24, 2019 · 8 comments
Closed

Is it possible to show the displayName text as label? #2

paule96 opened this issue Sep 24, 2019 · 8 comments
Assignees
Labels
enhancement New feature or request

Comments

@paule96
Copy link

paule96 commented Sep 24, 2019

Hi Author,

this extension is super cool. But I use in my templates very often the tag displayname. This tag can contain a custom name. This will be interpreted for example by the vscode outline extension for ARM. It would be created if I can show this display names in the graph too.

@benc-uk benc-uk added this to Under Consideration in Main Project Sep 24, 2019
@MaximRouiller
Copy link

It is also interpreted by the Visual Studio JSON Outline tool.

This is a must-have for anyone wanting to customize the name of the labels without having to change the name of the resources.

@benc-uk
Copy link
Owner

benc-uk commented Sep 26, 2019

Interesting. I wasn't aware of this convention. Thanks!

Ok so if displayName or displayname is present in the tags list, it can take the place of the resources's name field.

That's pretty easy :)

@benc-uk benc-uk added the enhancement New feature or request label Sep 26, 2019
@benc-uk benc-uk self-assigned this Sep 26, 2019
@benc-uk benc-uk moved this from Under Consideration to In progress in Main Project Sep 26, 2019
@MaximRouiller
Copy link

It's definitely a "convention" and not in the spec. It's how people are using some extensions to clarify graphs. Let me see if I can grab an existing template, open it in Visual Studio and show you what is displayed.

@MaximRouiller
Copy link

Without :
image

With:
image

@MaximRouiller
Copy link

This is present in Visual Studio 2019 Preview and was available for a long time before. The fun part, it doesn't impact functionality as it is a totally opt-in scenario.

@benc-uk benc-uk moved this from In progress to Done in Main Project Sep 27, 2019
@benc-uk
Copy link
Owner

benc-uk commented Sep 27, 2019

Added in https://github.com/benc-uk/armview-vscode/releases/tag/0.1.0

@benc-uk benc-uk closed this as completed Sep 27, 2019
@paule96
Copy link
Author

paule96 commented Sep 28, 2019

That was fast 👌

@benc-uk
Copy link
Owner

benc-uk commented Sep 28, 2019

I was already making a lot of changes to support linked templates, this was easy to fit in by comparison 😛

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Main Project
  
Done
Development

No branches or pull requests

3 participants