Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PowerMining Directive Exception #166

Closed
OverlordQ opened this issue May 11, 2020 · 3 comments
Closed

PowerMining Directive Exception #166

OverlordQ opened this issue May 11, 2020 · 3 comments

Comments

@OverlordQ
Copy link

OverlordQ commented May 11, 2020

Issue summary

Throwing exception when trying to clean up PowerMining Directives

Steps to reproduce:

  1. Spawn
  2. Wait for RCL8
  3. Wait for PM Directives to be expire

Error message:

[2:49:58 PM][shard2]TypeError: Cannot read property 'roomName' of undefined
    at DirectivePowerMine.get print [as print] (main:13792:71)
    at new Directive (main:13740:58)
    at new DirectivePowerMine (main:31722:9)
    at DirectiveWrapper (main:33219:28)
    at _Overmind.registerDirectives (main:35243:15559)
    at _Overmind.build (main:35243:11168)
    at Object.main [as loop] (main:36117:18)
    at __mainLoop:1:52
    at __mainLoop:2:3
// Offending line:
return '<a href="#!/room/' + Game.shard.name + '/' + this.pos.roomName + '">[' + this.name + ']</a>';

Suggested fix (optional):

Other information:

‣ Version:        Overmind v0.5.2
‣ Checksum:       0x0
‣ Assimilated:    No (clearance code: null) [WIP]
‣ Operating mode: automatic

Commit: c1cccf3

@MatthewARoy
Copy link
Collaborator

@OverlordQ Was this with an automatically created directive or a manually placed one?
Did you delete the directive?

@MatthewARoy
Copy link
Collaborator

Also is this on master or dev branch?

@OverlordQ
Copy link
Author

OverlordQ commented May 11, 2020

Automatic.

No.

Dev.

I threw a try/catch around log.alert(`Removing expired directive ${this.print}!`); in the Directive constructor and it seems to have moved on.

Of note, this was on the PTR, and might be related to the CPU sub's weekly reset, so things might have gone wonky when the max CPU was chopped to 20CPU.

So whatever cleanup was being done may have only half executed.

This is probably and edge case, but it may or may not crop up again if somebody bangs up against the CPU limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants