Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Haul flags get removed without hauling complete #73

Closed
mlinky opened this issue Feb 28, 2019 · 1 comment
Closed

Haul flags get removed without hauling complete #73

mlinky opened this issue Feb 28, 2019 · 1 comment

Comments

@mlinky
Copy link

mlinky commented Feb 28, 2019

Issue summary

If a haul flag is placed on an abandoned terminal or storage it gets removed before the available resources are removed.

Description of issue:

If a haul flag is placed on an abandoned terminal or storage it gets removed before the available resources are removed.

Steps to reproduce:

Place a haul flag on an abandoned terminal and wait a while, the flag will be removed

Error message:

n/a

// Offending line:

	if (_.sum(this.store) == 0 && this.pos.isVisible) {
		this.remove();			
	}

Suggested fix (optional):

This makes it behave differently, but this has stopped the flag being removed for me

	if (this.totalResources == 0) {
		log.info(`Removing ${this.name} - resources exhausted.`);
		this.remove();
	} 

Other information:

  • Overmind version: {found in package.json or by typing info() into console}

‣ Version: Overmind v0.5.2
‣ Checksum: 0x3f4a8c27850
‣ Assimilated: No (clearance code: null) [WIP]
‣ Operating mode: automatic

@mlinky
Copy link
Author

mlinky commented Feb 28, 2019

Sorry, mis-typed the comment in the suggested fix.

bencbartlett pushed a commit that referenced this issue Jun 14, 2019
* fix hauling flag/directive

* fix hauling flag/directive

* fix hauling flag/directive - removed if visible too

* added total remaining resources to notifcation info

* added total remaining resources to notifcation info 2

* package.json!

* uninstall lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants