Develop query #15
Merged
Develop query #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated tests&README accordingly increased timeout for deleteDatabase() test
…ncreased timeout in tests for deleteDatabase()
|
Ok, I've added a warning and the options now have a "devmode" flag. Hope that does the job. let me know what you think. |
|
no need to be sorry, I'm gonna change it :) |
|
I hope you don't mind me using yoda conditions. |
…development', NODE_ENV == undefined. Default log function (console.log) can be overidden
| request({ | ||
| url: this.url('db/' + this.options.database + '/series', { q: query }), | ||
| json: true | ||
| }, this._parseCallback(callback)); | ||
| }; | ||
|
|
||
| // legacy function | ||
| InfluxDB.prototype.readPoints = function(query, callback) { | ||
| if (false !== this.options.depreciatedLogging) this.options.depreciatedLogging('influx.readPoints() has been depreciated, please use influx.query()'); |
There was a problem hiding this comment.
if ( false !== this.options.depreciatedLogging)
|
Just that one change, then I'm happy for you to merge this into master! |
|
ok, I removed it. Would you also bump the version afterwards? |
|
Hm...the failed build looks like an issue with travis to me |
|
Yep it was a Travis issue. It's due to the reporting of coverage to Coveralls.io which I should probably put as an after_script. |
bencevans
added a commit
that referenced
this pull request
Feb 5, 2014
Added `query()` and depreciated `readPoints()`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
renamed readpoints() to query()