Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/query options #32

Merged
merged 4 commits into from
Jun 11, 2014
Merged

Conversation

nichdiekuh
Copy link
Collaborator

Fixes issue #31

@nichdiekuh
Copy link
Collaborator Author

Hm, not sure if I messed up my git :-/

@bencevans
Copy link
Member

History looks funny but changes are correct

@nichdiekuh
Copy link
Collaborator Author

Besides the timeouts in one of build the tests look fine to me.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling fa364ce on nichdiekuh:bugfix/query-options into 7bcfa30 on bencevans:master.

@bencevans
Copy link
Member

I restarted the build and it's continually happening :\ Is it passing on
your local machine?

On Fri, Jun 6, 2014 at 5:53 PM, Coveralls notifications@github.com wrote:

[image: Coverage Status] https://coveralls.io/builds/842259

Coverage remained the same when pulling fa364ce
fa364ce
on nichdiekuh:bugfix/query-options
into 7bcfa30
7bcfa30
on bencevans:master
.


Reply to this email directly or view it on GitHub
#32 (comment).

@nichdiekuh
Copy link
Collaborator Author

You mean the timeout errors? I usually have one or two, it got a bit worse with the latest influxdb versions. We can only raise the timeout value step by step and see if it works

@bencevans
Copy link
Member

Yep let's do that, I'd rather they always passed on Travis if they're going
to work.
On 6 Jun 2014 19:06, "Steffen" notifications@github.com wrote:

You mean the timeout errors? I usually have one or two, it got a bit worse
with the latest influxdb versions. We can only raise the timeout value step
by step and see if it works


Reply to this email directly or view it on GitHub
#32 (comment).

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 04aa90e on nichdiekuh:bugfix/query-options into 7bcfa30 on bencevans:master.

@nichdiekuh
Copy link
Collaborator Author

Looks good to me now, what do you think?

@bencevans
Copy link
Member

Yep! Let's merge!

bencevans added a commit that referenced this pull request Jun 11, 2014
@bencevans bencevans merged commit 63ad829 into node-influx:master Jun 11, 2014
@nichdiekuh nichdiekuh deleted the bugfix/query-options branch July 29, 2014 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants