Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the continuous query endpoints have been dropped in influx v0.8.5 #54

Merged
merged 3 commits into from
Oct 28, 2014

Conversation

nichdiekuh
Copy link
Collaborator

This PR requires a major version update. The response from the SQL API is in a different format

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.26%) when pulling a12d95c on nichdiekuh:bugfix/getContinuousQueries into 1678d5e on bencevans:master.

@bencevans
Copy link
Member

Please could you fix the tests and if possible write a test that covers what's missing in the report.

Cheers,

Ben

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling d3e7ac5 on nichdiekuh:bugfix/getContinuousQueries into 1678d5e on bencevans:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 8e79f0a on nichdiekuh:bugfix/getContinuousQueries into 1678d5e on bencevans:master.

@nichdiekuh
Copy link
Collaborator Author

The decreased code coverage was caused by the failed dropContinuousQuery test. I've fixed it and the coverage is at 100% again.

@bencevans
Copy link
Member

Looks good! Feel free to merge and release :shipit:

nichdiekuh added a commit that referenced this pull request Oct 28, 2014
the continuous query endpoints have been dropped in influx v0.8.5
@nichdiekuh nichdiekuh merged commit bec74fd into node-influx:master Oct 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants