Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added protocol option #63

Merged
merged 6 commits into from
May 7, 2015
Merged

added protocol option #63

merged 6 commits into from
May 7, 2015

Conversation

janza
Copy link
Contributor

@janza janza commented May 5, 2015

enables https support by setting protocol option to 'https'

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling d6c82da on janza:master into b559924 on bencevans:master.

@bencevans
Copy link
Member

Thanks! If you could add a test for using the HTTPS protocol it be much appreciated :)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling b98116e on janza:master into b559924 on bencevans:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 7baf93a on janza:master into b559924 on bencevans:master.

@janza
Copy link
Contributor Author

janza commented May 6, 2015

@bencevans OK, tests are in.

@bencevans
Copy link
Member

That's brilliant, thank you very much 🍻

bencevans added a commit that referenced this pull request May 7, 2015
@bencevans
Merge pull request #63 from janza/master
1bae6a8 
added protocol option
@bencevans bencevans merged commit 1bae6a8 into node-influx:master May 7, 2015
@bencevans bencevans mentioned this pull request May 11, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@janza @coveralls @bencevans