Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect artifact creation when target is a directory starting with dot #291

Closed
zuzuleinen opened this issue Dec 9, 2022 · 1 comment · Fixed by #294
Closed

Incorrect artifact creation when target is a directory starting with dot #291

zuzuleinen opened this issue Dec 9, 2022 · 1 comment · Fixed by #294
Assignees
@zuzuleinen
Labels
bug Something isn't working

Comments

@zuzuleinen
Copy link
Contributor

A task with directory target starting with . will remove the dot when creating the artifact.

 targetwithdirs:
    cmd: |-
      mkdir -p .bbuild/dirone/dirtwo
      touch .bbuild/dirone/fileone
      touch .bbuild/dirone/filetwo
      touch .bbuild/dirone/dirtwo/fileone
      touch .bbuild/dirone/dirtwo/filetwo
    target: .bbuild/dirone/

The above task will create an artifact with bbuild instead of .bbuild breaking the subsequent unpacks.
@zuzuleinen zuzuleinen added the bug Something isn't working label Dec 9, 2022
@zuzuleinen zuzuleinen self-assigned this Dec 19, 2022
@zuzuleinen zuzuleinen mentioned this issue Dec 19, 2022
Merged
5 tasks
@zuzuleinen
Copy link
Contributor Author

This issue will be fixed by #294

@zuzuleinen zuzuleinen linked a pull request Dec 19, 2022 that will close this issue
Hotreloading #294
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zuzuleinen zuzuleinen

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Hotreloading benchkram/bob
1 participant
@zuzuleinen