Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn lint breaks _typography.scss #51

Closed
apokokki opened this issue May 28, 2018 · 4 comments
Closed

yarn lint breaks _typography.scss #51

apokokki opened this issue May 28, 2018 · 4 comments

Comments

@apokokki
Copy link

apokokki commented May 28, 2018

"yarn lint" breaks _typography.scss file in windows 10 after clean install (tested with two machines).

yarn lint
yarn run v1.7.0
$ eslint --ext .js,.vue --fix . && stylelint --fix "src//*.vue" "src//.scss" && markdownlint docs/.md .md && prettier --list-different --write "**/.{js,json,css,scss,vue,md}"
src\design_typography.scss
error Command failed with exit code 1.

@stuta
Copy link

stuta commented May 29, 2018

I quess this is crlf vs lf problem.

@stuta
Copy link

stuta commented May 29, 2018

Yarn lint works after changing line endings from crlf to lf.

Maybe adding file .gitattributes * text eol=lf would be good.
Also changing in all windows gitconfig -files autocrlf = input helps.

@chrisvfritz
Copy link
Collaborator

I believe this should only be a problem with versions of Git prior to 2.10, but I just added a .gitattributes file to fix it in those older versions. Thanks @apokokki for the report and @stuta for the research. 🙂

@apokokki
Copy link
Author

apokokki commented Jun 7, 2018

Thanks Chris - problem solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants