Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete Option is Deleting Excluded Files #52

Closed
mmarcuccio opened this issue Jan 23, 2018 · 3 comments
Closed

Delete Option is Deleting Excluded Files #52

mmarcuccio opened this issue Jan 23, 2018 · 3 comments

Comments

@mmarcuccio
Copy link

When using the --delete and --exclude options, index files excluded by the filter are still deleted. It looks like deletes happen before exclusion filters are accounted for.

Here are the relevant lines from the log:

Deleting existing barrel @ D:/SRC/Redacted/portal/src/state/ducks/displayTemplate/index.ts
...
D:/SRC/Redacted/portal/src/state/ducks/displayTemplate/index.ts is excluded by /.*\.d\.ts|.*\/ducks\/.*\/.*/
@bencoveney
Copy link
Owner

Thanks for the bug report 👍

Hadn't considered the interaction between the include/exclude and delete options but removing people's files when they aren't expecting it could be a real pain so I'll try and get this resolved.

@bencoveney
Copy link
Owner

The fix for this issue is being worked on in https://github.com/bencoveney/barrelsby/commits/delete-filters

@github-actions
Copy link

No activity has been seen recently, marking as stale. If this is a mistake please reach out to a collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants