Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds activesupport as runtime dependency. #55

Merged
merged 1 commit into from Mar 30, 2014
Merged

Conversation

ream88
Copy link
Contributor

@ream88 ream88 commented Mar 30, 2014

I had problems using your gem without Rails. Loading a model which includes Mongoid::Tree fails with

NameError: uninitialized constant Mongoid::Tree::ActiveSupport

This commit fixes the dependency.

@benedikt
Copy link
Owner

Hi,

as the gem depends on mongoid, which depends on activmodel, which depends on activesupport this shouldn't be an issue. The gem itself is tested without rails and there were no problems up to now. Can you tell a bit more about your use case?

Bests,

Benedikt

@ream88
Copy link
Contributor Author

ream88 commented Mar 30, 2014

Ok, what about requiring active_support at the beginning of tree.rb? Doing this in my local fork did fix all problems for me.

@benedikt
Copy link
Owner

Yes, that sounds like a good idea. Can you please change the pull request accordingly? Thanks! :)

@ream88
Copy link
Contributor Author

ream88 commented Mar 30, 2014

Done :)

@ream88
Copy link
Contributor Author

ream88 commented Mar 30, 2014

Should I squash them?

@benedikt
Copy link
Owner

That would be great :)

@ream88
Copy link
Contributor Author

ream88 commented Mar 30, 2014

Sorry f**ked up git first, but now everything should work!

@benedikt
Copy link
Owner

👍 Thanks a lot, Mario!

benedikt added a commit that referenced this pull request Mar 30, 2014
Adds activesupport as runtime dependency.
@benedikt benedikt merged commit d792828 into benedikt:master Mar 30, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants