You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello @benfred. I think there might be an issue with the computation of NDCG in ranking_metrics_at_k. I believe NDCG should be calculated by first sorting the recommended ids by the recommendation scores, so that the logarithmic discount is applied in the correct ranking of the recommendations. Right now, Implicit's recommend methods do not return the ids sorted by their descending scores, so the way NDCG is being calculated does not take into account the order of the ranking.
I would appreciate your opinion, maybe I'm missing something and I'm wrong. Thanks in advance.
If changes turn out to be necessary, I would suggest adding some lines on this part of ranking_metrics_at_k
I guess this issue can be closed, since the bug of sorting the output of KNN models was fixed in November 2022 with #629. @malonsocortes Let us know if the issue still remains unsolved for you.
Hello @benfred. I think there might be an issue with the computation of NDCG in ranking_metrics_at_k. I believe NDCG should be calculated by first sorting the recommended ids by the recommendation scores, so that the logarithmic discount is applied in the correct ranking of the recommendations. Right now, Implicit's recommend methods do not return the ids sorted by their descending scores, so the way NDCG is being calculated does not take into account the order of the ranking.
I would appreciate your opinion, maybe I'm missing something and I'm wrong. Thanks in advance.
If changes turn out to be necessary, I would suggest adding some lines on this part of ranking_metrics_at_k
The text was updated successfully, but these errors were encountered: