-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rbspy as an inspiration? #10
Comments
rbspy was the inspiration for this project! I mentioned that quickly in the README here https://github.com/benfred/py-spy/#credits . The flamegraph code is actually taken directly from rbspy , and I've tried to give attribution for that. |
Excellent! Can't imagine how I missed that. Cool tool! |
Recently I stumbled upon https://www.polarsignals.com/blog/posts/2023/03/28/how-to-read-icicle-and-flame-graphs/ and noticed that py-spy draw icicle graph but in red, based on the article flame graph should be bottom up, and icicle graph should be blue, although it did mentioned that the color does not matter. |
My first thought on seeing this repo was that it seems to have been inspired by Julia Evans' https://github.com/rbspy/rbspy. They share some similarities in terms of being profilers of dynamic languages written in rust, using the name spy, and generating icicle graphs.
Might it be worth mentioning that inspiration somewhere in the readme?
The text was updated successfully, but these errors were encountered: