Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rbspy as an inspiration? #10

Closed
dswalter opened this issue Sep 6, 2018 · 3 comments
Closed

Rbspy as an inspiration? #10

dswalter opened this issue Sep 6, 2018 · 3 comments

Comments

@dswalter
Copy link

dswalter commented Sep 6, 2018

My first thought on seeing this repo was that it seems to have been inspired by Julia Evans' https://github.com/rbspy/rbspy. They share some similarities in terms of being profilers of dynamic languages written in rust, using the name spy, and generating icicle graphs.

Might it be worth mentioning that inspiration somewhere in the readme?

@benfred
Copy link
Owner

benfred commented Sep 6, 2018

rbspy was the inspiration for this project! I mentioned that quickly in the README here https://github.com/benfred/py-spy/#credits . The flamegraph code is actually taken directly from rbspy , and I've tried to give attribution for that.

@benfred benfred closed this as completed Sep 6, 2018
@dswalter
Copy link
Author

dswalter commented Sep 6, 2018

Excellent! Can't imagine how I missed that.

Cool tool!

@pickfire
Copy link

pickfire commented Apr 4, 2023

Recently I stumbled upon https://www.polarsignals.com/blog/posts/2023/03/28/how-to-read-icicle-and-flame-graphs/ and noticed that py-spy draw icicle graph but in red, based on the article flame graph should be bottom up, and icicle graph should be blue, although it did mentioned that the color does not matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants