Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ability to include module jars for preproc, completion, et al #522

Open
benfry opened this issue Jul 31, 2022 · 3 comments
Open
Labels
Help Wanted We have very little time and would like some help Preprocessor

Comments

@benfry
Copy link
Owner

benfry commented Jul 31, 2022

It's not currently possible to use other JavaFX classes from the PDE, even when it's in use as a renderer: processing/processing4-javafx#15

We'll need to see how to include .jar files from the modules path for preprocessing and compilation. Once that's set, getting them working with runtime shouldn't be too much trouble.

@vsquared
Copy link

vsquared commented Mar 15, 2023

https://github.com/processing/processing4/blob/3185ebae15f1ee894a9a2a056cc253b4677012e3/java/src/processing/mode/java/JavaBuild.java line 1086. Would adding javafx.controls fix it? If you're going to include swing components you might as well add javafx controls.

@benfry
Copy link
Owner Author

benfry commented Mar 16, 2023

That fixes one narrow problem regarding JavaFX (which is the cited example in the original post), but doesn't fix the broader issue. The broader issue is what this issue is about.

@vsquared
Copy link

What's wrong with adding all the modules:
"--add-modules", "javafx.base,javafx.graphics,javafx.swing,javafx.controls,javafx.fxml,javafx.media,javafx.web",

If that's a problem then consider adding a setting in Preferences to allow the user to choose the modules that they want to be included in JavaFX projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Help Wanted We have very little time and would like some help Preprocessor
Projects
None yet
Development

No branches or pull requests

2 participants