-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Library version number parsing does not ignore comments #586
Comments
Ah, that makes more sense than the report in #553. Should be straightforward to fix. |
Fixed for 4.0.2. The problem was that in-line comments (versus comments starting at the beginning of a line) were disabled so that it was possible to parse hex colors from settings files. (Otherwise, a hex color just looks like a comment.) Split the two cases and we should be all set. |
This issue has been automatically locked. To avoid confusion with reports that have already been resolved, closed issues are automatically locked 30 days after the last comment. Please open a new issue for related bugs. |
Description
Processing 4 Contribution Manager appears to include
# comments
in the property values, which causes number parsing forversion
value to fail.It looks like maybe this was already reported in #553 but it was closed for inactivity.
Expected Behavior
If the properties file includes a line like:
The parser should ignore the
#
and everything after it when retrieving the value.Processing 3.5.4 appears to do this correctly.
Current Behavior
Processing 4.0.1 includes comments in the library
prettyVersion
and complains about "The version number for “XXX” is not a number."Steps to Reproduce
nub
orwebsockets
Your Environment
Possible Causes / Solutions
The text was updated successfully, but these errors were encountered: