Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/identities/:id should return 404 when identity doesn't exist #41

Open
bjoerge opened this issue Jan 3, 2013 · 0 comments
Open

/identities/:id should return 404 when identity doesn't exist #41

bjoerge opened this issue Jan 3, 2013 · 0 comments
Labels

Comments

@bjoerge
Copy link
Member

bjoerge commented Jan 3, 2013

It currently gives status code 200 and request body {}.

Any fix for this issue should be done carefully as there may be a lot of code depending on the current status code and response body.

A likely consequence of fixing this issue, xhr success callbacks in JavaScript will never be called and needs to be used as error callbacks instead.

Also requests done through Pebblebed::Http.perform will need to be wrapped in begin/rescue.

I guess its an open question whether this bug is worth fixing. At least in v1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant