Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Jirc) Lirc parser shortcomings #101

Closed
bengtmartensson opened this issue Feb 19, 2016 · 1 comment
Closed

(Jirc) Lirc parser shortcomings #101

bengtmartensson opened this issue Feb 19, 2016 · 1 comment

Comments

@bengtmartensson
Copy link
Owner

The Lircd,conf parser has a few shortcomings: it rejects command names containing the bar ("|") as well as some "magical" names, like end. The reason is a combination of Lirc's absence of an strict description of the grammar of its configuration files, and the rigidity of the Antlr3 parser.

It is not really a showstopper, since the main usage of the Lirc import feature is the one-time import of lircd.conf files, and for this import, they can be hand edited with minor effort. Nevertheless, a better solution would be desirable.

Priority: low.

@bengtmartensson bengtmartensson changed the title Lirc parser shortcomings (Jirc) (Jirc) Lirc parser shortcomings Feb 25, 2016
bengtmartensson added a commit that referenced this issue Mar 27, 2016
Parser newly written, junked the old parser (Configfile.g). Removed much
dead code, incl Hardware.java. General cleanup.
@bengtmartensson
Copy link
Owner Author

All of the mentioned problems, plus a few more, have been addressed.

@bengtmartensson bengtmartensson added this to the Release 1.2. milestone Apr 28, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant