Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake and pkgconfig support #71

Closed
otavio opened this issue Oct 3, 2018 · 3 comments
Closed

CMake and pkgconfig support #71

otavio opened this issue Oct 3, 2018 · 3 comments

Comments

@otavio
Copy link

otavio commented Oct 3, 2018

We have been using this library for a while (since 2011) and we made a few changes on it. We'd like to contribute them back if you think it makes sense.

  • CMake
  • pkgconfig

Please let me know if a PR is desired. I can rebase our changes and prepare it.

@benhoyt
Copy link
Owner

benhoyt commented Oct 3, 2018

Hi @otavio, thanks for that. I'm uncertain about including make/build stuff in such a tiny project. But I don't know much about CMake or pkgconfig, so I'm open to hearing more or seeing your PR.

@otavio
Copy link
Author

otavio commented Oct 3, 2018

It is a widely used build system and it integrates way with cross-building environments. We did change the library to build static libraries for C and C++ and the pkgconfig allows for easy integration on existing projects.

A snapshot of what we use is here: https://github.com/OSSystems/inih

I need to rework this code and prepare a PR if you think this is worth.

@benhoyt
Copy link
Owner

benhoyt commented Oct 3, 2018

Hi @otavio: I think I'd rather not include these. Not because they're not useful or a bad idea, but because then I'd have to maintain files/systems I know nothing about, and I don't have much bandwidth for inih at this point. Sorry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants