Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opening-trainer #149

Closed
HarryBroeken opened this issue Sep 13, 2023 · 1 comment
Closed

opening-trainer #149

HarryBroeken opened this issue Sep 13, 2023 · 1 comment

Comments

@HarryBroeken
Copy link

I had some issues with the Opening-trainer.
I'am using scid-4.7.0-r1 in Linux-gentoo

I was able to resolve the issues by applying the following patch

--- opening.old.tcl 2023-09-06 19:37:03.657183737 +0200
+++ opening.tcl 2023-09-06 19:38:55.541989107 +0200
@@ -549,7 +549,7 @@
append tmp $m " "
set nlist [lindex $cm [expr $x+1] ]
if {$nlist == 0} { continue }

  •  if {$displayCMValue} {
    
  •  if {info exists $displayCMValue} {
       foreach n $nlist {
         append tmp $n " "
       }
    

The issues I experienced have probably something to do with; that in the Openings-trainer I use backward going through the game to see if there are alternatives for the move I played when training.

The patch seems to resolve this; looking at the tcl-code "info exists" is probably what was meant; could be a change in tcl.

I hope this info is usefull.

greetings<<
Harry

@HarryBroeken
Copy link
Author

The patch I gave above is not correct.
It should be

--- /usr/share/scid/tcl/tools/opening.old.tcl 2023-09-06 19:37:03.657183737 +0200
+++ /usr/share/scid/tcl/tools/opening.tcl 2023-09-15 21:49:44.157495479 +0200
@@ -549,7 +549,7 @@
append tmp $m " "
set nlist [lindex $cm [expr $x+1] ]
if {$nlist == 0} { continue }

  •  if {$displayCMValue} {
    
  •   if {[info exists displayCMValue]} {
       foreach n $nlist {
         append tmp $n " "
       }
    

@benini benini closed this as completed Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants