Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with noCheckOutDates in reverse order in v4.3.3 #133

Closed
JordyGit opened this issue Aug 8, 2022 · 3 comments
Closed

Issue with noCheckOutDates in reverse order in v4.3.3 #133

JordyGit opened this issue Aug 8, 2022 · 3 comments

Comments

@JordyGit
Copy link
Contributor

JordyGit commented Aug 8, 2022

#127 is fixed in normal order, but some cases that should be allowed in reverse order (with selectForward: false) are now disabled that shouldn't.

Gif:
StillSmallBugWithNoCheckInOutDatesInReverseOrder

Code:

var rangePicker = new HotelDatepicker(pickerEl, {
		inline: true,
		clearButton: true,
		submitButton: true,
		topbarPosition: 'bottom',
		submitButtonName: 'name_of_submit_button',
		moveBothMonths: true,
		selectForward: false,
		startOfWeek: 'monday',
		endDate: maxDate,
		format: 'DD/MM/YYYY',
		noCheckInDates: [
			'2023-07-03'
		],
		noCheckOutDates: [
			'2023-07-04'
		]
	});
@benitolopez
Copy link
Owner

benitolopez commented Aug 8, 2022

Seems that the problem is related to noCheckOutDates only. Can you confirm? noCheckInDates is working correctly from your gif.

@JordyGit
Copy link
Contributor Author

JordyGit commented Aug 8, 2022

Yes indeed, after watching it again, you are right

@JordyGit JordyGit changed the title Issue with noCheckInDates/noCheckOutDates in reverse order Issue with noCheckOutDates in reverse order Aug 8, 2022
@JordyGit JordyGit changed the title Issue with noCheckOutDates in reverse order Issue with noCheckOutDates in reverse order in v4.3.3 Aug 8, 2022
@benitolopez
Copy link
Owner

Fixed in 82cca45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants