Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Month icons not initialized correctly after switching from landscape to portait for the first time #136

Closed
JordyGit opened this issue Aug 10, 2022 · 3 comments

Comments

@JordyGit
Copy link
Contributor

JordyGit commented Aug 10, 2022

The icons of the months are not initialized correctly on mobile when you go from portrait to landscape for the first time. (When it goes from single month to 2 month display)
After switching months one time it corrects itself and the issue is gone.

I'm using the moveBothMonths: true option.

(Iphone 12 pro max, ios 14.5.1)
See:

Video.mov
@JordyGit JordyGit changed the title Month icons not initialized correctly after switchen from landscape to portait for the first time Month icons not initialized correctly after switching from landscape to portait for the first time Aug 10, 2022
@JordyGit
Copy link
Contributor Author

JordyGit commented Aug 11, 2022

Also if you are at the last month an go from landscape to portait it resets to the first month.

And another one, in landscape the next or prev button is gone when you reach the end or start but it doesn't go away in portair, it's displayed but as expected it doesn't do anything anymore in that case.

@benitolopez
Copy link
Owner

Please check: 87e618a

Important: after the resize, months are reset. So if you have a valid selection, it goes to the months with that selection. If there's not a selection, you go to the first month.

So this:

Also if you are at the last month an go from landscape to portait it resets to the first month.

It is not a bug, it is how it works.

@JordyGit
Copy link
Contributor Author

Ok I understand but would expect it to go to the same month, that is why I thought it was a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants