Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci tests (#2) #3

Closed
wants to merge 23 commits into from
Closed

Ci tests (#2) #3

wants to merge 23 commits into from

Conversation

emilpriver
Copy link

hey 馃憦

Added Ci to build the project on:

  • Ubuntu 22.04
  • Ubuntu 20.04
  • macos 12
  • macos 11
  • Windows 2022 (server)
  • Windows 2019 (server)

Don't seem as we are able to use for example windows 10 but windows server does the job aswell.

I also added a linter which complains about normal problems: https://github.com/rust-lang/rust-clippy
and rust fmt check.

emilpriver and others added 16 commits October 17, 2022 22:59
* added CI for rust

* worked on rust targets

* added colon

* added cache

* added runs on

* added toolchain

* changed key

* worked on ci

* removed toolchain

* removed some targets

* dev

* clippy fix and removed target

* removed target

* fixed clippy issues

* removed target and added delete on warnings
@emilpriver
Copy link
Author

It's is possible to build/test into different rust targets. But don't think it needed atm

@emilpriver
Copy link
Author

emilpriver commented Oct 17, 2022

Did see that GH is not running the actions unless you merge it @benja but here is a example of all tests: https://github.com/emilpriver/cloup/actions/runs/3269186840

@emilpriver
Copy link
Author

I recommend to Squash this PR

Copy link

@Brendonovich Brendonovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanted to get these review notes down before Benja forgets them

.github/workflows/test-rust.yaml Outdated Show resolved Hide resolved
src/commands/init.rs Outdated Show resolved Hide resolved
@emilpriver emilpriver closed this Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants