Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GroupBy usage with tags #3

Closed
4nte opened this issue Apr 30, 2019 · 2 comments
Closed

GroupBy usage with tags #3

4nte opened this issue Apr 30, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@4nte
Copy link

4nte commented Apr 30, 2019 •
edited

GroupBy currently supports only time periods (GROUP BY time())
I suggest that we introduce QueryBuilder.GroupByTag() and QueryBuilder.GroupByTime() for clarity.

Also GroupByTime could accept time.Duration as a param instead of a string.

What do you think?
@4nte 4nte changed the title GroupBy tags feature GroupBy usage with tags Apr 30, 2019
@benjamin658
Copy link
Owner

benjamin658 commented May 24, 2019 •
edited

Hi, thank you for your recommendation, I think it is a good idea to enhance and clarify the GroupBy method.

I have already made this PR to enhance this feature #5 , you can see the usage of the GroupByTime and GroupByTag in README or in test case.

@4nte
Copy link
Author

4nte commented May 24, 2019

Beautiful! Thanks for the efforts, the lib is very useful.

@benjamin658 benjamin658 added the enhancement New feature or request label May 27, 2019
@4nte 4nte closed this as completed May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@benjamin658 @4nte