Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GroupBy usage with tags #3

Closed
antegulin opened this issue Apr 30, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@antegulin
Copy link

commented Apr 30, 2019

GroupBy currently supports only time periods (GROUP BY time())
I suggest that we introduce QueryBuilder.GroupByTag() and QueryBuilder.GroupByTime() for clarity.

Also GroupByTime could accept time.Duration as a param instead of a string.

What do you think?

@antegulin antegulin changed the title GroupBy tags feature GroupBy usage with tags Apr 30, 2019

@benjamin658

This comment has been minimized.

Copy link
Owner

commented May 24, 2019

Hi, thank you for your recommendation, I think it is a good idea to enhance and clarify the GroupBy method.

I have already make this PR to enhance this feature #5 , you can see the usage of the GroupByTime and GroupByTag in README or in test case.

@antegulin

This comment has been minimized.

Copy link
Author

commented May 24, 2019

Beautiful! Thanks for the efforts, the lib is very useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.