Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a supportCustomVibrations method #34

Closed
Skyost opened this issue Jun 4, 2020 · 3 comments
Closed

Add a supportCustomVibrations method #34

Skyost opened this issue Jun 4, 2020 · 3 comments

Comments

@Skyost
Copy link
Contributor

Skyost commented Jun 4, 2020 •
edited
Loading

Hey.

I love the latest plugin update that added the CoreHaptics support. Would it be possible for you to create a method (can be named supportCustomVibrations or whatever) which would return :

  • true on Android.
  • true on CoreHaptics iOS devices (and false on older devices).

This way, we could have a better control on which devices we can play custom vibrations, and on which devices it's not possible to do so.

Thanks !
@benjamindean
Copy link
Owner

Sure! Good idea. Will implement it as soon as I can.

@Skyost Skyost mentioned this issue Jun 4, 2020
Merged
@Skyost
Copy link
Contributor Author

Skyost commented Jun 4, 2020

Just submitted a pull request that should do the job.

@benjamindean
Copy link
Owner

Closed in #35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Skyost @benjamindean