New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use new `Asset::getContents()` method #63

Closed

benjamminf opened this issue May 8, 2018 · 0 comments

Contributor

benjamminf commented May 8, 2018

Currently reading the contents of the JSON file is done manually (https://github.com/benjamminf/craft-embedded-assets/blob/master/src/Service.php#L109). Would be better to leverage the new Asset method introduced in 3.0.6 (https://github.com/craftcms/cms/blob/develop/src/elements/Asset.php#L915).

benjamminf added a commit that referenced this issue


          #63 Simplified file reading and probably made it more robust

4fe7222

benjamminf closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment