Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report form errors without losing filled out form #1

Closed
benjamminf opened this issue Dec 6, 2015 · 3 comments
Closed

Report form errors without losing filled out form #1

benjamminf opened this issue Dec 6, 2015 · 3 comments
Assignees
@benjamminf
Labels
bug

Comments

@benjamminf
Copy link
Collaborator

If you try to save a field that contains errors in the form (invalid field handle, some required field not being filled out, etc) it will close the modal and report that something went wrong, but you'll lose everything you filled out.

It should report errors for individual fields without closing the modal.
@benjamminf benjamminf self-assigned this Dec 6, 2015
@benjamminf
Copy link
Collaborator Author

It seems I didn't test this properly. It doesn't actually close the modal window, however the only error reported is "An unknown error has occurred"

@benjamminf
Copy link
Collaborator Author

(Close and comment and Comment buttons are a little too close together...)

@benjamminf benjamminf reopened this Dec 7, 2015
benjamminf added a commit that referenced this issue Dec 7, 2015
@benjamminf
Slightly better error reporting #1
c2e7858 
Just displays a notice at the top of the page with the errors that
occurred when saving a field. It doesn't however capture errors with
field type settings.

Reloading the template with inline error reporting is what's next.
benjamminf added a commit that referenced this issue Dec 7, 2015
@benjamminf
Resolved issue #1
994f488 
Form now updates to show errors on the form itself. The AJAX is very
fiddly and I'm suspect there'll be some edge case bugs here and there.
@benjamminf
Copy link
Collaborator Author

This has been resolved for version 0.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benjamminf benjamminf

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benjamminf