Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Form ID's not correctly namespaced #2

Closed
benjamminf opened this issue Dec 6, 2015 · 1 comment
Closed

Form ID's not correctly namespaced #2

benjamminf opened this issue Dec 6, 2015 · 1 comment
Assignees
@benjamminf
Labels
bug

Comments

@benjamminf
Copy link
Collaborator

At the moment the form has element ID's that aren't getting namespaced, so there's possibility of ID clashing which will affect scripts from running correctly.

There's actually a working example of this - the "name" and "handle" fields already exist on some pages, so the handle script doesn't execute correctly.
@benjamminf benjamminf added the bug label Dec 6, 2015
@benjamminf benjamminf self-assigned this Dec 6, 2015
benjamminf added a commit that referenced this issue Dec 7, 2015
@benjamminf
Resolved issue #2
e485be0 
Just hardcoded the namespace for the id's as this modal is static
anyway.
@benjamminf
Copy link
Collaborator Author

This has been resolved for version 0.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@benjamminf benjamminf

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@benjamminf