Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin no longer works due to API deprecation #48

Closed
msbentley opened this issue Aug 6, 2021 · 2 comments
Closed

Plugin no longer works due to API deprecation #48

msbentley opened this issue Aug 6, 2021 · 2 comments

Comments

@msbentley
Copy link

msbentley commented Aug 6, 2021

See this post. The plugin no longer loads in the latest dev version of Joplin (2.2.4) because of this.

The console shows:

/tmp/.mount_Joplin3o96lm/resources/app.asar/node_modules/@joplin/lib/Logger.js:188 11:10:29: joplin.plugins: Uncaught exception in plugin "joplin.plugin.note.tabs": Error: "joplin.plugin.note.tabs": No longer supported: joplin.settings.registerSetting() is deprecated in favour of joplin.settings.registerSettings() (deprecated since version 1.8)
    at Plugin.deprecationNotice (/tmp/.mount_Joplin3o96lm/resources/app.asar/node_modules/@joplin/lib/services/plugins/Plugin.js:117)
    at JoplinSettings.<anonymous> (/tmp/.mount_Joplin3o96lm/resources/app.asar/node_modules/@joplin/lib/services/plugins/api/JoplinSettings.js:85)
    at Generator.next (<anonymous>)
    at /tmp/.mount_Joplin3o96lm/resources/app.asar/node_modules/@joplin/lib/services/plugins/api/JoplinSettings.js:8
    at new Promise (<anonymous>)
    at __awaiter (/tmp/.mount_Joplin3o96lm/resources/app.asar/node_modules/@joplin/lib/services/plugins/api/JoplinSettings.js:4)
    at JoplinSettings.registerSetting (/tmp/.mount_Joplin3o96lm/resources/app.asar/node_modules/@joplin/lib/services/plugins/api/JoplinSettings.js:84)
    at Object.<anonymous> (/tmp/.mount_Joplin3o96lm/resources/app.asar/node_modules/@joplin/lib/services/plugins/utils/executeSandboxCall.js:50)
    at Generator.next (<anonymous>)
    at /tmp/.mount_Joplin3o96lm/resources/app.asar/node_modules/@joplin/lib/services/plugins/utils/executeSandboxCall.js:8
@benji300
Copy link
Owner

benji300 commented Aug 6, 2021

Thanks for reporting. I've already changed the implementation on a branch. Hopefully I can create a new version next week.

@benji300
Copy link
Owner

Fixed with latest release v1.4.0 (#50)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants